search

JoshMarler / react-juce

Write cross-platform native apps with React.js and JUCE
https://docs.react-juce.dev
MIT License
763 stars 79 forks source link

Fix issues with react-juce hot reload on recent npm versions #276

Closed JoshMarler closed 2 years ago

JoshMarler commented 3 years ago

@nick-thompson , if you're happy to give this a final check I can do the necessary npm bumps and merge. Will run lint step. Things now working under both Duktape and Hermes

nick-thompson commented 3 years ago

@JoshMarler looks like 0.2.15 is live on npm– should be good to merge here then, yea?

JoshMarler commented 3 years ago

@JoshMarler looks like 0.2.15 is live on npm– should be good to merge here then, yea?

Hey,

It's working under Hermes but stupidly I'd not regenerated from cmake cache properly and something under Duktape is still broken. I'll get this fixed over the weekend and then probably have to do a second bump. Apologies, ran out of time for this due to new job onboarding.

nick-thompson commented 3 years ago

Ah got you, no problem! No rush