search

JoshMcguigan / belay

Run your CI checks locally to `git push` with confidence
Apache License 2.0
41 stars 1 forks source link

Fix windows support. #3

Closed TheGoddessInari closed 4 years ago

TheGoddessInari commented 4 years ago

This got broken after a few days.

If not obvious, the #[cfg(not(windows))] block is only for things that are absolutely not supported on Windows, like the concept of UNIX modes, for which there is no equivalent. Windows uses ACLs exclusively, and the current user defaults to full control (including execute) for files it creates.

No such limitations on HashSet that I'm aware of.

JoshMcguigan commented 4 years ago

No such limitations on HashSet that I'm aware of.

My apologies, that must have been an IDE auto-import. Thanks for the PR!

JoshMcguigan commented 4 years ago

This has been published as version 0.5.0.