fix: 'test_exiftool()'s 'system2()' version call

JoshOBrien / exiftoolr

ExifTool Functionality from R

https://joshobrien.github.io/exiftoolr/

23 stars 1 forks source link

fix: 'test_exiftool()'s 'system2()' version call #11

Closed trevorld closed 2 years ago

trevorld commented 2 years ago

Now: system2(command, args = args, stdout = TRUE, stderr = FALSE) returns version number as intended.
Previous: system2(command, args = args, stderr = FALSE) returns 0 (since command didn't fail) and prints out version number even if quiet = TRUE. Note as.numeric(0) still successfully casts as a numeric so wasn't throwing an error...
Not entirely sure why there is a paste( collapse = "\n") but I assume you had a reason (for Windows?)

JoshOBrien commented 2 years ago

@trevorld Thanks for that well-explained PR.

I no longer fully remember why I put the paste( collapse = "\n") in there, but think I did have a reason. Since it's doing no harm, and may have been used to handle some exceptional circumstance, I'll leave it in there.