search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 187 forks source link

Release RC3 #294

Closed JoshOrndorff closed 4 years ago

JoshOrndorff commented 4 years ago

This PR performs the procedure for cutting a release from the contributing guidelines. It releases the 2.0.0-rc2 version of the recipes.

The Recipes follows gitflow discipline for releasing versions. In terms of gitflow, you are here:

release-prep

Being a release preparation PR, this PR contains all the changes that have been merged into the develop branch since the RC2 release. Reviewing the entire set of changes is certainly welcome, but is not necessary as they have already been reviewed in their individual PRs. To review only this prep work, it is best to look at the 5 release-prep commits.

Edit: GRRR this PR is still showing all the commits since we started using gitflow. I thought it would just show the changes since the last release.

JoshOrndorff commented 4 years ago

This all looks good to me too. For some reason the link-checker is failing. The first link it reports broken is substrate.dev/rustdocs/v2.0.0-rc3/sc_consensus_pow/trait.PowAlgorithm.html. Investigatin with curl I get

$ curl substrate.dev/rustdocs/v2.0.0-rc3/sc_consensus_pow/trait.PowAlgorithm.html
<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>
</html>

Loading in my browser it looks fine. Regardless the link checker reports status 400 (Bad Request). I've re-run the job several times over the last two days and gotten the same result every time. I also reported the issue upstream. I guess there are a few options for moving forward:

  1. Merge this anyway so we don't hold up the RC3 release
  2. Find a different link checker (context: devhub has tried a few and aren't happy with any yet)
  3. Do both 1 and 2
  4. Other ideas?
JoshOrndorff commented 4 years ago

Okay adding the https back to the rustdocs links fixed the ci error. I'm glad the CI caught that because I didn't actually intend to remove the https.

wheresaddie commented 4 years ago

thank you Joshy you're the best