JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs

GNU General Public License v3.0

378 stars 187 forks source link

Remove clippy warning suppression #306

Closed JoshOrndorff closed 4 years ago

JoshOrndorff commented 4 years ago

In https://github.com/substrate-developer-hub/recipes/pull/305/commits/062d8f74a3e8bf5c5d3b7b1294488272c58a1849 I added several warning suppression lines. They were necessary due to the implementation of impl_runtime_apis! and decl_runtime_apis!. This has now been fixed upstream in Substrate https://github.com/paritytech/substrate/pull/6540

Next time we update to a more recent Substrate, these lines should be removed.

herou commented 4 years ago

I am going to work on this if nobody else is working on it. Is it okay?

herou commented 4 years ago

Created a PR for that.

wheresaddie commented 4 years ago

thank you @herou if the PR isnt already closed- can you link it here for record/follow up

herou commented 4 years ago

@wheresaddie it is already closed.

JoshOrndorff commented 4 years ago

@herou 's PR (#332) was opened before the recipes were updated enough to remove these lines. In my PR to update to RC5 (#333), I've included his work.

wheresaddie commented 4 years ago

thanks @JoshOrndorff

JoshOrndorff commented 4 years ago

333 is not merged yet. Let's keep this open until it is. Just in case we don't merge #333 for some reason, then we don't lose track of this issue.

herou commented 4 years ago

I guess you included my work in #333 ?

JoshOrndorff commented 4 years ago

Yes! Thank you!