search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 187 forks source link

Update offchain-demo with less byte conversion & using StorageLock #310

Closed jimmychu0807 closed 4 years ago

jimmychu0807 commented 4 years ago

Also updated the recipe text to reflect latest code change.

jimmychu0807 commented 4 years ago

@danforbes @wheresaddie

I have some update on the off-chain demo recipe. My hope is getting your review and could merge this to master. An alternative would be to wait till Joshy come back, but prefer not to wait this long. Thanks.

Btw, link check fails at 

https://wiki.parity.io/Substrate-Style-Guide → Status: 404

Do we still have a style guide, or should just remove the link?

wheresaddie commented 4 years ago

@danforbes @wheresaddie

I have some update on the off-chain demo recipe. My hope is getting your review and could merge this to master. An alternative would be to wait till Joshy come back, but prefer not to wait this long. Thanks.

Btw, link check fails at

https://wiki.parity.io/Substrate-Style-Guide → Status: 404

Do we still have a style guide, or should just remove the link?

remove for now

jimmychu0807 commented 4 years ago

@danforbes @wheresaddie Thank you all for the review! 🙏