search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 186 forks source link

Update runtime-api.md #312

Closed mkdior closed 4 years ago

mkdior commented 4 years ago

Added some more information regarding custom type definitions. Also fixed one typo, if this is too basic please disregard, thanks.

mkdior commented 4 years ago

Much appreciated @bkchr

danforbes commented 4 years ago

@Meuko to fix the build you need to update the reference to the rc2 docs in this file https://github.com/Meuko/recipes/blob/patch-1/CONTRIBUTING.md

danforbes commented 4 years ago

Oops I'm sorry there are many references to rc2 docs. Are you able to see this @Meuko? https://github.com/substrate-developer-hub/recipes/pull/312/checks?check_run_id=947223614 You can try running something like this to update all the links https://github.com/substrate-developer-hub/substrate-developer-hub.github.io#updates Here is the actual script https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/blob/source/scripts/update-kb-rustdocs

mkdior commented 4 years ago

Oops I'm sorry there are many references to rc2 docs. Are you able to see this @Meuko? https://github.com/substrate-developer-hub/recipes/pull/312/checks?check_run_id=947223614 You can try running something like this to update all the links https://github.com/substrate-developer-hub/substrate-developer-hub.github.io#updates Here is the actual script https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/blob/source/scripts/update-kb-rustdocs

Seems some were missed, my apologies, I'll fix them tomorrow morning. Thanks for the heads up!