search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 187 forks source link

Docker container for each node #329

Closed JoshOrndorff closed 2 years ago

JoshOrndorff commented 4 years ago

Solves #266

This PR introduces a docker image for each node in the recipes. This will allow learners to quickly run and experiment with the nodes without having to compile them. Of course we hope the learners will eventually compile and hack on the nodes, but these images provide a lower-friction way to get started.

This is done and working, but I have not merged it because the images are currently pushed to my own personal dockerhub account.

jimmychu0807 commented 3 years ago

@JoshOrndorff I want to resolve this PR (hopefully finish this up).

What problem are you trying to solve? What is the status of this PR as you know of (pretty much done? otherwise, what's left?) How should I test this? (Specifically, can I run this / the test without pushing to github?)

JoshOrndorff commented 3 years ago

@jimmychu0807 I've edited the title and description to give you a better sense of what this PR is doing.

When I last worked on it, it was working as I expected. I didn't merge it because the docker images are pushed to my personal dockerhub account and I didn't know if the devhub team wanted that. Personally, I'm fine with it, but I can see why it would be more "official" looking to use a devhub or parity dockerhub account. That's up to you guys.

Since the last time I worked on it, other changes have been made to the ci and there are now merge conflicts so you'll need to merge master and resolve the conflicts. If you need help resolving the conflicts @TriplEight is probably a good person to ask as he did the ci overhaul.