search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 186 forks source link

Issue #306 removed the clippy warning suppression #332

Closed herou closed 4 years ago

herou commented 4 years ago

-removed the clippy warning suppression

herou commented 4 years ago

I removed the clippy lines of code but I do not understand what went wrong. I thought those lines were not used anymore. Do you have any suggestions?

JoshOrndorff commented 4 years ago

The idea is that those lines will bot be needed once the recipes are updated to rc5. I'm working on that now, but I'm struggling. A lot has changed since RC4 in the service. I'll use this commit once that update is done.

Also, it is good to base each PR off of the master branch. I see this one includes a commit you made for a different PR.

herou commented 4 years ago

The idea is that those lines will bot be needed once the recipes are updated to rc5. I'm working on that now, but I'm struggling. A lot has changed since RC4 in the service. I'll use this commit once that update is done.

Also, it is good to base each PR off of the master branch. I see this one includes a commit you made for a different PR.

My previous PR was merged into the master.