search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 187 forks source link

Added a new directory for node-templates with different consensus and runtime configurations #347

Closed Gauthamastro closed 4 years ago

Gauthamastro commented 4 years ago

I am working on babe-grandpa and staking based runtime. It was hard for beginners like me to change consensus from AURA to BABE in the substrate node template repo (especially the lib\service.rs file in node side). Suppose we can provide a directory with different commonly used combinations of consensus and runtime as node templates. It will be easier for newcomers to immediately begin their business logic part with any combination provided here instead of having AURA as the only option for them in node templates.

I have included a template with BABE, GRANDPA & Staking enabled in the latest version v2.0.0-rc6.

JoshOrndorff commented 4 years ago

Thanks for this PR @Gauthamastro. I agree replacing Aura with Babe can be challenging the first time you do it. Swapping consensus in general can be complex. I hope you found our examples of using PoW, Hybrid PoW+GRANDPA, and instant seal somewhat useful for the big picture concepts. And also took a look at the Polkadot node which uses Babe.

Unfortunately, we can't accept this PR right now because we don't have enough bandwidth to keep it maintained as Substrate changes. I actually just removed a recipe on a BABE GRANDPA node as part of the RC5 release (#333).

We'd encourage you to publish this elsewhere though, maybe keep a fork or as a blog post. If you send the link we'll link to it in the awesome Substrate list and point other users to it.

darkfriend77 commented 3 years ago

@Gauthamastro Thank you for this pull request, it is of great value for me even if it hasn't been accepted. I had a lot of trouble doing just what you have done here. Your implementation of BABE, GRANDPA & Staking helped me a lot.

Gauthamastro commented 3 years ago

@Gauthamastro Thank you for this pull request. It is of great value for me even if it hasn't been accepted. I had a lot of trouble doing just what you have done here. Your implementation of BABE, GRANDPA & Staking helped me a lot.

Happy to know it helped you. 😄