Revert "- replaced uwrap with expect"

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs

GNU General Public License v3.0

376 stars 186 forks source link

Revert "- replaced uwrap with expect" #374

Closed wheresaddie closed 3 years ago

wheresaddie commented 3 years ago

Reverts substrate-developer-hub/recipes#371

herou commented 3 years ago

@wheresaddie, @wheresaddie Since I do not know very well the project I need a bit of help from you guys. The expect("msg to print") method should print meaningful msg. Would be nice if you can provide the list of the msg that you want to print and then I can replace them. Note: This comment is copied and pasted from the previous PR

jimmychu0807 commented 3 years ago

Closing this for now. I would say if we have meaningful error message to display, then by all means use expect(), otherwise let's stick with unwrap().