JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
376 stars 186 forks source link

The warn from the future! #376

Open TriplEight opened 3 years ago

TriplEight commented 3 years ago

I ran the CI test against a newer CI image with

rustc 1.46.0 (04488afe3 2020-08-24)
rustc 1.48.0-nightly (7402a3944 2020-09-13)

And the error is

Checking sum-storage-rpc v2.0.0 (/__w/recipes/recipes/pallets/sum-storage/rpc)
error: unnecessary closure used to substitute value for `Option::None`
##[error]  --> pallets/sum-storage/rpc/src/lib.rs:62:26
   |
62 |           let at = BlockId::hash(at.unwrap_or_else(||
   |  ________________________________^
63 | |             // If the block hash is not supplied assume the best block.
64 | |             self.client.info().best_hash));
   | |_________________________________________^ help: Use `unwrap_or` instead: `at.unwrap_or(self.client.info().best_hash)`
   |
   = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

error: aborting due to previous error
##[error]aborting due to previous error
error: could not compile `sum-storage-rpc`
##[error]could not compile `sum-storage-rpc`
To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
##[warning]error: build failed
##[error]The process '/usr/local/cargo/bin/cargo' failed with exit code 101
TriplEight commented 3 years ago

To test, change the image tag to :production