search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
379 stars 187 forks source link

update type Event in tight and cargo fmt #402

Closed honeywest closed 3 years ago

honeywest commented 3 years ago

pub trait Trait: system::Trait + vec_set::Trait The logic is like this type Event should add Self as vec_set

// type Event: From<Event > + Into<::Event>; type Event: From<Event>+ Into<::Event>+ Into<::Event>;

danforbes commented 3 years ago

@honeywest can you explain why this change is necessary? Maybe another one @JoshOrndorff may have thoughts on?

JoshOrndorff commented 3 years ago

@honeywest Thanks for the answers. I'm glad you're inspecting and learning from the recipes :+1:

I think this trait bound change is not needed. However, it would be nice to have your formatting changes. Would you mind reverting that one trait bound change, and keeping the formatting changes?

honeywest commented 3 years ago

thank you very much. now I close. Maybe after a period of time, I understand completely and then reopen.