search

JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 188 forks source link

Proof-reading edits :bowtie: #405

Closed sacha-l closed 3 years ago

sacha-l commented 3 years ago

Simple edits to make Recipes prettier. Most of the changes are things like adding in semicolons and capitalizing the R for "Rust". Others include clarification nitpicks.

Note WIP: This first batch of edits only includes 1.1 - 1.6.

danforbes commented 3 years ago

Thank you for opening this PR @sacha-l 🙏🏻 Since you mentioned it is a WIP I have converted it to a draft for the time being. I'll be keeping my eyes on this PR 👀 and definitely let me know if you have any specific questions I can help with 🤓

jimmychu0807 commented 3 years ago

@sacha-l Thank for working on this PR. This PR looks pretty good to me, is it ready to be converted to an official PR and I will take a look and merge if okay?

sacha-l commented 3 years ago

Thanks for taking a look at this PR @jimmychu0807. I'm happy you like the changes, however I think I'd rather have this PR merged once I get around to going through all of Recipes. This PR only goes through Recipes 1.1 - 1.6. I feel that if you merged it as is it would add more inconsistencies.

I'm planning on submitting a PR with a new structure for all Recipes in there as well as including the types of changes proposed in this current PR throughout.

Hope that makes sense to you! Let me know your thoughts?

Le mar. 26 janv. 2021 à 16:41, Jimmy Chu notifications@github.com a écrit :

@sacha-l https://github.com/sacha-l Thank for working on this PR. This PR looks pretty good to me, is it ready to be converted to an official PR and I will take a look and merge if okay?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/substrate-developer-hub/recipes/pull/405#issuecomment-767902660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRULJEGBZCNH376ETOSFNDS35HLVANCNFSM4VNM2UKQ .

jimmychu0807 commented 3 years ago

Very cool @sacha-l. Thanks for the contribution and take your time. Let me know if I can be of any assistance.