JoshOrndorff / recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
378 stars 188 forks source link

Most links to Substrate Playground are not working #422

Closed jimmychu0807 closed 3 years ago

jimmychu0807 commented 3 years ago

Tried on the following pages:

Clicking on the "Playground Try It" button returns me the following message:

Screenshot 2021-03-31 at 12 26 01

JoshOrndorff commented 3 years ago

I'd guess this is a playground issue. @jeluard

jeluard commented 3 years ago

A session is still active. You can only have one session active at a time.

@jimmychu0807 How could I make this more explicit? I already discuss that very point with you :)

nuke-web3 commented 3 years ago

Possibly by making that error code more prominent and adding the context you just did @jeluard ?

you can only have one active substrate playground session open at a time.

please close (or end/terminate) all other sessions to open a new one

Something like this?

jimmychu0807 commented 3 years ago

@jeluard but that's the first link I click that land me to playground on that day. I just tried again (and I guarantee you this is the first time I arrive on playground today), and still showing me the same error message: A session is still alive.

I know. May I have a button that "close all other sessions and launch this one" button?

jeluard commented 3 years ago

@jimmychu0807 my bad, I just checked and there is indeed a regression .. 🤦 I will fix it and improve the error message so that there is no more possible confusion.

jeluard commented 3 years ago

@jimmychu0807 @NukeManDan I pushed a fix. Could you check and tell me what you think?

jimmychu0807 commented 3 years ago

@jeluard once you deployed the playground-staging to production, please notify us here. I will retest the recipe-playground integration. Thanks!

jeluard commented 3 years ago

Just deployed on production.

jimmychu0807 commented 3 years ago

There is some other issue but I will close it here, and I love the "Replace Existing Session" button @jeluard . Thanks.