search

JoshOrndorff / substrate-recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
380 stars 184 forks source link

New branch for pallets frame V2 #458

Open herou opened 3 years ago

herou commented 3 years ago

Hi @JoshOrndorff , @jimmychu0807

I was able to convert simple-event pallet into frame v2: https://github.com/herou/recipes/tree/simple_event_frame_v2, the node can run without a problem and I fixed the tests as well.

Simple-map converted: https://github.com/herou/recipes/tree/simple_map_v2 :) Hello-substrate: https://github.com/herou/recipes/tree/hello_substrate_v2

I would suggest that somebody of you can create a branch that would contain all the pallets that I would convert from frame v1 to frame v2.

If better idea please let me know.

whereistejas commented 3 years ago

+1 for merging this. This helped me out a lot.

herou commented 3 years ago

Finally all the pallet are converted from v1 to v2 : https://github.com/herou/recipes/tree/simple_event_frame_v2 @whereistejas @JoshOrndorff Do you want to check this and why not merging it :)

JoshOrndorff commented 3 years ago

I don't maintain this repo anymore, so I don't have power to merge. But I know that the first step is to open a PR. Or PRs if you have two different branches.

JoshOrndorff commented 3 years ago

There's no reason anyone wants to keep the old FRAME v1 stuff around, so we should just replace it with your updated versions as you make them.

JoshOrndorff commented 3 years ago

This work is merged now, so I'll close this issue.