JoshOrndorff / substrate-recipes

A Hands-On Cookbook for Aspiring Blockchain Chefs
GNU General Public License v3.0
380 stars 184 forks source link

Converted pallet to frame v2 #471

Closed herou closed 3 years ago

herou commented 3 years ago

All the recipes have been converted to frame v2.

herou commented 3 years ago

@JoshOrndorff Can you please take a look and give me a hand with fixing the above issues

herou commented 3 years ago

@JoshOrndorff @jimmychu0807 This PR is just one step ahead of being merged and helping the community. Please, let a look. Thank you!

jimmychu0807 commented 3 years ago

@herou thank you for your contribution. But we will soon deprecated this repository and use the how-to guide. Please wait for one more week, and you should see a brand-new substrate doc site.

herou commented 3 years ago

@herou thank you for your contribution. But we will soon deprecated this repository and use the how-to guide. Please wait for one more week, and you should see a brand-new substrate doc site.

I assume the documentation will be update according to frame v2. How abou the pallets? Can you give to me some more details? Are you open for contributors to the new repo? Thank you!

sacha-l commented 3 years ago

Hi @herou thanks for contributing here, I'm sure it will be helpful for many that use Recipes. To reiterate what @jimmychu0807 said, in archiving the Recipes repository, we would be happy to see the community continue to maintain it however, we will no longer maintain it and focus our efforts on the Substrate how-to guides instead. You'll notice that several of these guides are taken from the Recipes. Feel free to contribute any new guides or improvements there. This is always greatly appreciated!

herou commented 3 years ago

reiterate

@sacha-l @jimmychu0807 Can you please take a look at this PR and merge it if possible? It would help the community. Some link checks are failing.

sacha-l commented 3 years ago

@herou: I fixed the broken link. You've made significant improvements, well done. But the Substrate Developer hub team is no longer going to be reviewing PRs here going forward. Would you be interested in becoming an owner of this repository to keep Recipes as community maintained ?

herou commented 3 years ago

@herou: I fixed the broken link. You've made significant improvements, well done. But the Substrate Developer hub team is no longer going to be reviewing PRs here going forward. Would you be interested in becoming an owner of this repository to keep Recipes as community maintained ?

@herou: I fixed the broken link. You've made significant improvements, well done. But the Substrate Developer hub team is no longer going to be reviewing PRs here going forward. Would you be interested in becoming an owner of this repository to keep Recipes as community maintained ?

@sacha-l It would be nice to be the owner of this repo, I have worked a lot here.