Create `Substrate Bitcoin` repo to be a Git Submodules for this workshop repo

JoshOrndorff / utxo-workshop

A Substrate UTXO workshop

The Unlicense

117 stars 81 forks source link

Create `Substrate Bitcoin` repo to be a Git Submodules for this workshop repo #61

Closed nczhu closed 4 years ago

nczhu commented 4 years ago

Create a separate repo called "Substrate Bitcoin" which contains your latest PR and the full PoW implementation. I feel like keeping this repo as a "workshop" devalues how functional and comprehensive it is, for teams that want to implement Bitcoin chains.

This way, workshop version control becomes a bit easier. Specifically, the following branches:

Workshop: can point to the latest commit, ex UTXO.rs file which contains the exercises
Startercode: points to Nicole's commit before the PoW changes.

@JoshOrndorff I think this will make this repo less confusing to navigate. thoughts?

JoshOrndorff commented 4 years ago

I agree separating the utxo workshop from the entire bitcoin-like chain makes sense for sure.

I don't yet fully understand where the line will be drawn though. Would some code still live in this repo? If yes, would it include the utxo pallet? Would the Substrate Bitcoin repo also include that code, or depend o nit from this repo?

What if instead of getting its own repo, the bitcoin stuff became a recipe. Would that still work with your plan here?

nczhu commented 4 years ago

mm yeah... im overcomplicating things. Your suggestion of turning the PoW stuff into a recipe sounds great.

Let's merge your latest PR to this repo, once it's ready, and just keep the current repo/branch structure. I realize that keeping two separate repos, one for the full impl and one for the workshop boilerplates, doesn't simplify things all that much...