L,T,R,B differs between Rect and Circ

[tatarize]

Left, top, right, bottom.

circ->left = binaryReadInt16(file);
    circ->top = binaryReadInt16(file);
    circ->right = binaryReadInt16(file);
    circ->bottom = binaryReadInt16(file);

Top, Left, bottom, right.

    rect->top = binaryReadInt16(file);
    rect->left = binaryReadInt16(file);
    rect->bottom = binaryReadInt16(file);
    rect->right = binaryReadInt16(file);

Is this real or just a typo?

[JoshVarga]

Looks like a typo, I haven't reviewed that in some time, and was mainly used to parse/decode and not to actually read in and use the data.

On Thu, Apr 20, 2017 at 9:13 PM, tatarize notifications@github.com wrote:

Left, top, right, bottom.

circ->left = binaryReadInt16(file); circ->top = binaryReadInt16(file); circ->right = binaryReadInt16(file); circ->bottom = binaryReadInt16(file);

Top, Left, bottom, right.

rect->top = binaryReadInt16(file);
rect->left = binaryReadInt16(file);
rect->bottom = binaryReadInt16(file);
rect->right = binaryReadInt16(file);

Is this real or just a typo?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JoshVarga/libpes/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYcnBH3JmaVg0wmd8TY4Q2Fevay2f2Qks5ryBCugaJpZM4NDyIS .

[tatarize]

If the reading of the block description is accurate it means most all of the stuff is actually pretty easy. The description there is how the stitches are filled rather than anything about the shapes. Seems like it would be perfectly doable to simply read the shapes and the transformation and pretty directly transcode that into svg which equally allows matrix data and similar shapes. Though, I have never ever seen a copy of a pes with actual design details exist in the wild. So the general thrust of the idea seems pretty pointless. It was a poor choice by Brother to mesh those two completely distinct file types into the same file. Though a lot of embroidery software and design is similarly a series of poor design choices.

But hella solid work, mapping it out. I'm migrating the descriptions to frno7's wiki to fill in the missing sections, though I totally feel it's too cryptic a location. So is a text document in a github repository like Trevor's document there. You don't happen to know a reasonable open wiki-ish place to put a well explained technical document that like maybe a dozen people would ever care about. I'm pretty sure wikipedia frowns on such things.