search

Joshimuz / mcbingo

A Minecraft Bingo sheet generator
GNU Affero General Public License v3.0
28 stars 19 forks source link

Refactored generator_v3 #99

Closed Joshimuz closed 3 years ago

Joshimuz commented 3 years ago

Removed old comments, added new comments Removed unused variables Better creation of Indexes array Added tagCount list which keeps track of tags on the sheet and their amounts instead of recalculating the list/amount by checking every goal on the sheet every time a goal is generated! Added antisynergy, reactant and catalyst arrays, to keep track of what antisyergys etc are on the sheet instead of checking every goal on the sheet every time a goal is generated! Refactored check for if the goal is already on the sheet. Refactored check for same line tag collisions. Renamed cont to retry, moved it outside the do while loop (how did this even work anyway?). Removed constant refrences to cont when failing a goal check and instead just set retry to false ONCE at the end of the do while loop is all the checks are passed. Named do while loop GoalGen and continue that specifically when failing a check.

This addresses #98 AND THEN SOME

rybak commented 3 years ago

I can't do a full review right now. Will continue tomorrow, probably.

Joshimuz commented 3 years ago

I'll just assume it's fine :)