search

Josholith / gnome-extension-lan-ip-address

https://extensions.gnome.org/extension/1762/lan-ip-address/
Other
20 stars 18 forks source link

Copy to clipboard #21

Open keltroth opened 1 year ago

keltroth commented 1 year ago

My updated proposition to issue #2

Josholith commented 1 year ago

Thanks for the contribution. Ideally this branch would have been done with smaller logical commits. The one commit has both the new feature (copy to clipboard) and a JS refactor (var/let/const) and also some whitespace adjustments. With all the changes in a single commit, if there is a problem later, it is more effort to revert just part of the change (must edit files, can't use git revert). Not a show stopper, but just suggesting it for future contribs.