search

Joshua-Ashton / dxup

A d3d9 and d3d10 to d3d11 translation layer.
zlib License
259 stars 26 forks source link

[d3d9] Fix widechar conversion for winelib #28

Closed pchome closed 5 years ago

pchome commented 5 years ago

wcstombs creates garbage in device description for winelib WideCharToMultiByte used, see https://github.com/doitsujin/dxvk/blob/master/src/util/util_string.cpp

pchome commented 5 years ago

BTW: AppVeyor build failure caused by current master.

c:\projects\dxup\src\dx9asm\dx9asm_modifiers.cpp(66): error C2562: 'dxup::dx9asm::calculateDXBCModifiers': 'void' function returning a value [C:\Projects\DXUP\build\src\dx9asm\fda8aad@@dx9asm@sta.vcxproj]
         c:\projects\dxup\src\dx9asm\dx9asm_modifiers.cpp(21): note: see declaration of 'dxup::dx9asm::calculateDXBCModifiers'

Which I have fixed in previous PR, considering current master should be fine, and error is winelib (GCC) build specific.

Joshua-Ashton commented 5 years ago

I already have a fix for this locally, I'll look into wcstombs stuff though, but later.

pchome commented 5 years ago

Ok, then you probably should reject both PRs, and apply such fixes on your will at some point.

P.S. I should fix another merge conflict next time. No way :wink:

Joshua-Ashton commented 5 years ago

Yeah I'll reject them for now. It may be a better idea for you to, if you wanted, continue this work once d3d9 support becomes more mature. I'm constantly rewriting large portions of it which will undoubtedly cause more wine build issues in future.