search

Joshua-Ashton / dxup

A d3d9 and d3d10 to d3d11 translation layer.
zlib License
259 stars 26 forks source link

Add '--always' to vcs_tag in meson.build #48

Closed ComfyKernel closed 5 years ago

ComfyKernel commented 5 years ago

Without it there is a chance that the build will fail because git couldn't generate a full version name.

change

> ['git', 'describe' '--dirty=+']

to

> ['git', 'describe', '--always', '--dirty=+']
Joshua-Ashton commented 5 years ago

Hi, I actually didn't write this, I adapted dxvk's build scripts.

Is there a reason why this only affects dxup and the same doesn't apply to dxvk? (dxvk: https://github.com/doitsujin/dxvk)

ComfyKernel commented 5 years ago

It's possible this also affects DXVK, I just haven't had the need to build it in a long time since it's distributed on steam and in winetricks

Joshua-Ashton commented 5 years ago

Looked into this more, added it. Seems like it's needed when nothing is tagged.

Cheers!