search

Joshua-Data-Wizard / PyRealEstate

Creating a Library to help in the development and evaluation of real estate AVM's
MIT License
0 stars 1 forks source link

Adds requirements file #2

Closed kdschlosser closed 1 year ago

kdschlosser commented 1 year ago

Adds requirements,.txt file that holds a list of dependencies Completes the project information in pyproject.toml

kdschlosser commented 1 year ago

no worries m8

kdschlosser commented 1 year ago

I can tell that Python is not your native programming language. It's not C either. I can usually tell what a persons native language is. the 2 space indents and the use of the parenthesis makes me think C but there were no semicolons at all. so I am on the fence about what language is your preferred.

Joshua-Data-Wizard commented 1 year ago

So to be completely honest I do not know that I have a preferred I jumped around allot in school but having a bachelors in math I have used R by far for the longest. I think what you are kind of seeing is me mixing and matching the languages. I really do appreciate the review and straightening out of the code it is much cleaner!

kdschlosser commented 1 year ago

Not a big deal. There is nothing like this made for Python and it does help out a lot. Unfortunately there is no set standard across the country for doing home valuations and the only thing that can be made is something that makes a best efford to cover the different approaches.

Type hinting and documentation using the doc strings are a must to have so the user is able to tell what needs to be passed and what data needs to be passed.