Feature Request: updates and additional dto for mcp251x SPI CAN driver

jobafr commented 1 week ago

Feature Description

Hi,

thank you so much for this project! We'd like to use the linux-rockchip kernel with an mcp2515 CAN adapter connected to our Radxa Rock 5b on the spi0-m2-cs0 interface.

We'd like to use an up-to-date kernel as well, because there have been some nasty bugs in the old kernel version we got from Radxa's original Ubuntu 20.04 image. Your kernel has most of what we need, except for

the rk3588-spi0-m2-cs0-mcp2515-8mhz device tree overlay (this configuration is officially supported according to Radxa's pinout, but the dts file was added to their kernel at some later point at our request, so it probably wasn't in whatever version you pulled in here).
the latest bugfix to mcp251x in the upstream kernel

Would it be possible to pull these in here?

Side note, is it possible to build the kernel without cleaning the entire build directory? I've been using

sudo ./build.sh -ko --board=rock-5b -v -s jammy

so far and it takes ages. (I did change the kernel branch in config/suites/jammy.sh to noble so I can use the newest kernel on 22.04, which seems to work fine).

Joshua-Riek commented 1 week ago

Can you please open a pull request?

Compiling the kernel is the same as upstream Ubuntu.

# shellcheck disable=SC2046
export $(dpkg-architecture -aarm64)
export CROSS_COMPILE=aarch64-linux-gnu-
export CC=aarch64-linux-gnu-gcc
export LANG=C

# Compile the kernel into a deb package
fakeroot debian/rules clean binary-headers binary-rockchip do_mainline_build=true

jobafr commented 1 week ago

fakeroot debian/rules clean binary-headers binary-rockchip do_mainline_build=true

That takes ages, seemingly because it first removes all the build artifacts and rebuilds the entire thing. Is it possible to do an incremental build for testing? And maybe skipping the packaging/compression steps?

Can you please open a pull request?

I'd like to, but I'm unfamiliar with how you usually update the kernel. Is there some standard process that you use to bring in updates? Do we just merge some upstream branch or should I try to cherry-pick commits or copy/paste changes?

Joshua-Riek commented 1 week ago

I'm trying to take a much needed break. Please send a pull request if you would like these changes incorporated into the kernel.

jobafr commented 1 day ago

Ok. Here's the PR: https://github.com/Joshua-Riek/linux-rockchip/pull/30

Joshua-Riek / ubuntu-rockchip

Feature Request: updates and additional dto for mcp251x SPI CAN driver #1054

Feature Description