search

JoshuaBThompson / WristBand

WristBand Music Device
0 stars 0 forks source link

Restrict knob rotation while recording #136

Closed Alex-L-Crane closed 7 years ago

Alex-L-Crane commented 7 years ago

Based on our testing with Jason - while app is recording, lock knob to current position

JoshuaBThompson commented 7 years ago

@Alex-L-Crane but we still want to allow the user to select a new instrument even while the record is enabled for the current instrument right? That way they can just stop recording by selecting a new instrument.

Alex-L-Crane commented 7 years ago

@JoshuaBThompson We can discuss the details of this in person, but I think it will be better to prevent selecting a new instrument while recording. It will enforce a better user workflow.

JoshuaBThompson commented 7 years ago

@Alex-L-Crane ok, if that's the workflow it will be easy

Alex-L-Crane commented 7 years ago

Let's discuss it in more depth tomorrow. I think that will be the best workflow, but there are variations on how it can work - for example: instrument can not be changed while recording measures for the first time, but it overdubbing on already recorded measures, instrument can be changed and app will automatically be taken out of record mode

On Thu, Apr 6, 2017 at 12:18 AM, JoshuaBThompson notifications@github.com wrote:

@Alex-L-Crane https://github.com/Alex-L-Crane ok, if that's the workflow it will be easy

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/136#issuecomment-292089962, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtAaNbgPV2ik9uQ2ejN5GEEKi6mmFks5rtJHIgaJpZM4M0xwD .

JoshuaBThompson commented 7 years ago

@Alex-L-Crane Ok, I updated the knob with this logic and it works fine. I pushed this change to the beta_bugs branch.

JoshuaBThompson commented 7 years ago

fixed in beta