Fix loop workflow

[JoshuaBThompson]

Required loop workflow:

• [x] Record should only start after user presses 'play' then 'record'
• [x] For first instance of track record - if first recording of track, record should wait till next measure before actually recording anything (this provides user time to get ready)
• [x] For first instance of track record - If user stops recording then the record will actually stop an the end of the measure not exactly where the user stopped in time

[JoshuaBThompson]

Pushed some changes to GrooverAlpha. Play is now required to be pressed before record will register anything. Also, now each instrument has it's own aksequence track and the global click track is better managed.

[JoshuaBThompson]

@Alex-L-Crane Question about initially defining track measure length. If user adds a beat and then just sits there and doesn't press stop record or change to a new instrument track should the measure count keep increasing until they stop record / change instrument? Or, should we just set the measure count to wherever their last beat was recorded and round up to the nearest measure if even they just sit at the same beat? What if they want some padding time after they make the last beat in a track?

[Alex-L-Crane]

Yup, the measure count should just keep increasing. Remember, they can always shorten the loop later.

On Fri, Jul 29, 2016 at 1:56 PM, JoshuaBThompson notifications@github.com wrote:

@Alex-L-Crane https://github.com/Alex-L-Crane Question about initially defining track measure length. If user adds a beat and then just sits there and doesn't press stop record or change to a new instrument track should the measure count keep increasing until they stop record / change instrument? Or, should we just cut set the measure count to wherever their last beat was recorded and round up to the nearest measure?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/68#issuecomment-236291288, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtF6i9amgNqZ2_YKii03Q_mLmFTBUks5qamj7gaJpZM4JVS0q .

[JoshuaBThompson]

Ok, but should we put some limit on how long the measure count will keep increasing if they just sit their after making one beat?

[JoshuaBThompson]

Maybe like 1 minute or something?

[Alex-L-Crane]

No need to limit the count. If they just sit there, they don't have a clue what they're doing and they'll eventually stop the app and figure out what to do anyway.

On Fri, Jul 29, 2016 at 2:01 PM, JoshuaBThompson notifications@github.com wrote:

Ok, but should we put some limit on how long the measure count will keep increasing if they should sit their after making one beat?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/68#issuecomment-236292330, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtDYJnqimmJZpT8xyfTB7WZSnHK8cks5qamoOgaJpZM4JVS0q .

[JoshuaBThompson]

Also, if they make a beat on one track (first time for the track) and then switch to another track should we then set the track measure count to wherever the last beat to input was before moving on to the next track?

[JoshuaBThompson]

Ok, I see. Well, actually now that I think about it I'll have to put some kind of limit on it since the audiokit library will probably not like it if I make a track length super long... but yeah I get the gist of it.

[Alex-L-Crane]

That's an interesting question. My thoughts are that it might be a good idea to take it out of record mode when the track is switched (whitch would obviously also set the loop length), but it's a little hard to say without trying it out.

On Fri, Jul 29, 2016 at 2:03 PM, JoshuaBThompson notifications@github.com wrote:

Also, if they make a beat on one track (first time for the track) and then switch to another track should we then set the track measure count to wherever the last beat to input was before moving on to the next track?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/68#issuecomment-236292822, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtHe3Jjg85udB5y5FQ8AN9UddHHvqks5qamqQgaJpZM4JVS0q .

[JoshuaBThompson]

Yeah, I'll make that the default behavior for now and then we can update it once we start testing again :)

[Alex-L-Crane]

Yeah, I mean we could limit it to 200 measures or something crazy like that just to keep it from crashing the phone or using all of the memory or whatever. It should be some crazy long length that no one will ever surpass. Probably even longer than a minute.

On Fri, Jul 29, 2016 at 2:05 PM, Alex Crane alexcranedesigner@gmail.com wrote:

That's an interesting question. My thoughts are that it might be a good idea to take it out of record mode when the track is switched (whitch would obviously also set the loop length), but it's a little hard to say without trying it out.

On Fri, Jul 29, 2016 at 2:03 PM, JoshuaBThompson <notifications@github.com

wrote:

Also, if they make a beat on one track (first time for the track) and then switch to another track should we then set the track measure count to wherever the last beat to input was before moving on to the next track?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/68#issuecomment-236292822, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtHe3Jjg85udB5y5FQ8AN9UddHHvqks5qamqQgaJpZM4JVS0q .

[Alex-L-Crane]

Sounds good

On Fri, Jul 29, 2016 at 2:07 PM, Alex Crane alexcranedesigner@gmail.com wrote:

Yeah, I mean we could limit it to 200 measures or something crazy like that just to keep it from crashing the phone or using all of the memory or whatever. It should be some crazy long length that no one will ever surpass. Probably even longer than a minute.

On Fri, Jul 29, 2016 at 2:05 PM, Alex Crane alexcranedesigner@gmail.com wrote:

That's an interesting question. My thoughts are that it might be a good idea to take it out of record mode when the track is switched (whitch would obviously also set the loop length), but it's a little hard to say without trying it out.

On Fri, Jul 29, 2016 at 2:03 PM, JoshuaBThompson < notifications@github.com> wrote:

Also, if they make a beat on one track (first time for the track) and then switch to another track should we then set the track measure count to wherever the last beat to input was before moving on to the next track?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/68#issuecomment-236292822, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtHe3Jjg85udB5y5FQ8AN9UddHHvqks5qamqQgaJpZM4JVS0q .

[JoshuaBThompson]

Another question: Imagine this scenerio:

• Start recording and then wait say 10 sec then add a kick 1 beat and then wait another ten seconds
• Then immediately switch to the hat 1 instrument track make a beat, wait another 10 seconds and the stop recording
• So the kick 1 beat track loops every 20 seconds with a beat at time = 10 sec
• The hat 1 beat track loops every 30 seconds with a beat at time = 20 sec

The way it currently will work is that when you play your recorded track this will happen:

• After 10 seconds you will hear the kick 1 beat play
• Then after another 10 seconds (after the kick 1 beat has played) you will hear the hat 1 beat play
• At this pointer 20 seconds has elapsed
• The kick 1 beat track will then loop back to it's 0 point and start counting down till the next beat (10 seconds)
• The hat 1 beat track will still need to wait another 10 seconds till it loops back around
• After 10 more seconds you will hear the kick 1 beat and simultaneously the hat 1 beat track will restart
• After 20 seconds you will hear the hat 1 beat and also the kick 1 beat play at the same time

Is this ok?

[JoshuaBThompson]

So I also just added a pre-record click track that works like this:

• user hits play then hits record
• pre-record click track plays for one measure (you will here the hat 3 sound)
• User can play notes during the pre-record time but they will not be added to the loop
• Once the pre-record measure is finished notes played by the user will be added to the loop
• Also if the click track is selected then you will start hearing the normal click track sound again

[Alex-L-Crane]

This scenario is very hard to envision from a musical standpoint, but I think I get it. I need to sketch it out to confirm, but I think it is not correct. On playback I think hat one should play at the same time as kick one. I'll confirm after going over this in more depth

On Sat, Jul 30, 2016 at 2:02 PM, JoshuaBThompson notifications@github.com wrote:

Another question: Imagine this scenerio:

• Start recording and then wait say 10 sec then add a kick 1 beat and then wait another ten seconds
• Then immediately switch to the hat 1 instrument track make a beat, wait another 10 seconds and the stop recording

The way it currently will work is that when you play your recorded track this will happen:

• After ten seconds you will hear the kick 1 beat play
• Then after another 10 seconds (after the kick 1 beat has played) you will hear the hat 1 beat play
• At this pointer 20 seconds has elapsed
• The kick 1 beat track will then loop back to it's 0 point and start counting down till the next beat (10 seconds)
• The hat 1 beat track will still need to wait another 10 seconds till it loops back around
• After 10 more seconds you will hear the kick 1 beat and simultaneously the hat 1 beat track will restart
• After 20 seconds you will hear the hat 1 beat and also the kick 1 beat play at the same time

Is this ok?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoshuaBThompson/WristBand/issues/68#issuecomment-236389777, or mute the thread https://github.com/notifications/unsubscribe-auth/AL2NtEbqVQUKJ5uZJ65N8ltEz9KNlOsAks5qa7vogaJpZM4JVS0q .

[JoshuaBThompson]

Closing out this issue. newLooping branch has these fixes and will be merged to Groover-Alpha branch.