search

JoshuaBThompson / WristBand

WristBand Music Device
0 stars 0 forks source link

Integrate song deletion into UI #94

Closed Alex-L-Crane closed 7 years ago

Alex-L-Crane commented 7 years ago

I added a delete Icon to the prototype cell on the song list view. I also added an edit button to the header. Delete icon should be invisible until edit is clicked. At that point touching the delete icon will delete the corresponding song. Right now the song title looks squished because there should be no "Select" button. Please remove select button and attach select functionality to song title.

JoshuaBThompson commented 7 years ago

Hey, so I was about to implement the delete song functionality but did some reading and realized that we might want to use the standard iOS delete cell workflow. It's outlined here (at the very bottom of the page) Basically using the edit feature (like you included so far) will automatically create a delete button when you swipe. I think we should use this since it makes the delete cell from table workflow really easy (for me...). Otherwise we would be doing it a non standard way and it could make it hacky.

JoshuaBThompson commented 7 years ago

Also, I don't want to mess with the storyboard so could you remove the selec song button from the storyboard?

JoshuaBThompson commented 7 years ago

Fixed in beta and master branches