search

JoshuaBonn1 / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
0 stars 0 forks source link

prevent the timeline from being smaller than the height of the metarows + one cell #12

Closed ericfont closed 7 years ago

ericfont commented 7 years ago

Take a look at the right vertical scroll bar:

screenshot at 2017-08-07 23-21-43

Notice that it is displayed from the very top of timeline to the bottom of timeline. However, I believe it should only extend from the top of the actual cell data to the bottom of the cell data. This would be similar to how the bottom scroll bar extends. This will properly communicate to the user that the scroll bar only actually controls the cell data.

The way it is now becomes more problematic when the height of the timeline window is not tall enough to fit any cell data, in which case it looks like:

screenshot at 2017-08-07 23-23-27

And in which case the scroll bar has no apparent effect. User might think the scrollbar is broken in this case.

JoshuaBonn1 commented 7 years ago

I understand the reasoning behind this. However, I believe this might be a very large edit, as i am unsure if just rewritting the builtin functions or breaking the timeline grid and meta rows into two different widgets will work... I'm really not sure.

ericfont commented 7 years ago

oh, that must be because the horizontal scrollbar is using the built in extension but only extends on as far as it does because it uses the built in divider. How about this: can use use a vertical divider as well as horizontal divider? Then that would also allow the meta rows to scroll by themselves. Edit: I see this was your second option.

ericfont commented 7 years ago

Well I do think breaking it into two widgets is the proper way that this should have been done...it is unfortunate that neither of us realized this earlier.

ericfont commented 7 years ago

as a stop gap measure, I think you will need to prevent the timeline from being smaller than the height of the metarows + one cell. That way there is always some scroll-able cell region.

JoshuaBonn1 commented 7 years ago

That is definitely something I have thought about, however with the time of the GSoC running out, I'm worried that such a large change for a rather small issue would cause me to run out of time to polish up the timeline and make it much more presentable. I would say a stopgap measure would be a much better solution right now. (There is tons of code based on them being two widgets for the full timeline to do with overlapping the meta rows and selections as well as interactions between the labels and the main grid that would have to be rewritten)

ericfont commented 7 years ago

ok, then do the stopgap measure right now. Should be simple.

ericfont commented 7 years ago

I'm calling it a bug since scrollbar doesn't work in this situation.