ericfont
commented
7 years ago I'm noticing that Edit->Instruments visibility only affects visibility for the master score, not for the current part score in the scoreview. So I'm wondering maybe it doesn't make sense to have the mouseover eye icon appear when looking at a part score.
I believe I mentioned this somewhere else a while ago. But I'm trying your latest branch https://github.com/JoshuaBonn1/MuseScore/commit/3f6ef8b2ee53853f1ad49308d2777ec826c75c7d and I notice that the timeline of the part score is only showing the cell data for the part. But the timeline is supposed to represent the entire score. So even if just viewing a part, I would say that the timeline needs to use data from the parent score.
To create parts from a mulit-instrument score, go to File->Parts and then press "New All" and "OK", then you will see the parts as subtabs under the main scoreview tab.
Obviously for visibility coloring purposes, only the cells of the staffs in the current part score should be colored grey, while anything not in the current part score should be colored greencyan. I would say to also have the instrument names of the parts not in the current part be colored grey, just like you do when hiding instrumnets. I'm wondering if there should be a visual indicator to distinguish between hidden vs not in the part score. This is actually part of the reason why I was recommending keeing the eyes closed icon for instruments that have been hidden in #7. Maybe the instruments that are not in the current part score should have a parenthesis around them like "(instrument name)" in addition to being greyed out, so we know the difference.
In general what this means for coding is that the timeline should use Score::masterScore() for all timeline data, while visibility coloring shouldn't refer to masterScore() but should only be considered visible if is a part of current score && is the current scoreview says is visibile.