search

JoshuaBrookover / bigg

bgfx, imgui, glfw, glm
The Unlicense
226 stars 35 forks source link

Add const qualifiers to class member functions #11

Closed yuki-koyama closed 5 years ago

yuki-koyama commented 5 years ago

I added const qualifiers to bigg::Application's member functions. Specifically, I changed

I created a subclass derived from bigg::Application and I defined a member function in which getWidth() and getHeight() were used. I wanted to make the new member function const as it would not change anything, but it was not possible because getWidth() and getHeight() were not marked as const.

I am not aware of any disadvantages about not to mark member functions as const when applicable. However, please feel free to close (without merge) this PR if you intentionally dropped const qualifiers for some reasons.

Thank you for this very useful project.

JoshuaBrookover commented 5 years ago

Thank you, this was an oversight.