search

JoshuaBrookover / bigg

bgfx, imgui, glfw, glm
The Unlicense
226 stars 35 forks source link

Updated ImGui to 1.60 #3

Closed jreach-dev closed 6 years ago

jreach-dev commented 6 years ago

Both examples now work with ImGui 1.60

JoshuaBrookover commented 6 years ago

Thanks!

jreach-dev commented 6 years ago

@JoshuaBrookover No problem. I also updated bgfx but havn't pushed yet because it depends on your bgfx.cmake. Will fork that and do pull request as well.

Any idea on how to make texturev work or is it supposed to fail?

JoshuaBrookover commented 6 years ago

It works for me on Mac if I update to the latest bgfx.cmake. I start getting errors in bigg_imgui.hpp, but they are easily fixed. bx::fmin and bx::fmax were removed, so if I change to just fmin and fmax, I'm back up and running.

I see you've made the same fixes in #4

jreach-dev commented 6 years ago

Great. It appears updating fixed the texturev issue as well which is currently your only open issue 😃

JoshuaBrookover commented 6 years ago

Yes. Thank you for that!

jreach-dev commented 6 years ago

Thank you for taking the time to decouple all the components in bigg so cleanly. Makes it very easy to maintain.