search

JoshuaBrookover / bigg

bgfx, imgui, glfw, glm
The Unlicense
224 stars 35 forks source link

Updated BGFX for Bigg #4

Closed jreach-dev closed 6 years ago

jreach-dev commented 6 years ago

Sorry about the mess. I accidentally tangled the forks! What would be the proper way to pull request with submodules?

The good news is that this somehow resolved the texturev issue? Anyhow thanks for letting me help out.

JoshuaBrookover commented 6 years ago

I can squish the commits into something cleaner. I'm not sure that I trust GitHub to do it automatically when it comes to submodules. I will take this PR tonight when I have more time to do that thoroughly.

Or, if you could make a new PR with a cleaner history before tonight, I will take that instead.

jreach-dev commented 6 years ago

Sure. I will do that. Feel free to reject or rip things out if I do it incorrectly. I didn't know GitHub automatically sucks newer commits into older pull requests!

JoshuaBrookover commented 6 years ago

Live and learn. I will close when you have new PR.

I recommend creating a new branch for each change you wish to make whenever you fork a project. Then make a PR from that branch, instead of using master. Once I took your first change, you could merge my master into your second branch and you would have a clean history for your second PR.