JoshuaBuditama / slowvid

0 stars 2 forks source link

Issue #49: Upload complete page #83

Closed JoshuaBuditama closed 3 years ago

JoshuaBuditama commented 3 years ago

This pull request addresses issue #49 . When a verification upload process is successful, a pop-up message that indicates the success will be displayed. Currently it's displayed on top of the mock device display. Unsure of the cause of this. If it's an issue, I will be more than happy to try to fix the display so that the success message is displayed inside the container.

And also, I put the tests in the same folder as the components. We might need to move all of the tests in a separate folder eventually to make the files to be more organised but I believe that this should be addressed in a separate issue.

JakeBrown commented 3 years ago

@JoshuaBuditama I think the problem is trying to use Bulma's built in modal class for this. It's going to show the modal over the whole screen rather than within a parent element.

You could probably hack this with CSS to override Bulma but better options might be:

JoshuaBuditama commented 3 years ago

@JakeBrown Thanks heaps for your suggestions! What I ended up doing was just replacing the whole page with the success message on successful submission haha. It works sort of like moving to another page except that it actually does not. Would this be fine?

Edit: I just realised that what I did was exactly what you suggested in your first point. So hopefully this fix is ok haha.