search

JoshuaGrams / tiny-qbn

A storylets library for Twine2/Sugarcube.
https://joshuagrams.github.io/tiny-qbn/
Other
48 stars 3 forks source link

Escape spaces in passage name in visited tag #7

Closed mjhawkins closed 3 years ago

mjhawkins commented 3 years ago

Ensure that spaces in passage titles are escaped in the visited expression.

mjhawkins commented 3 years ago 
Glad you found my change useful. FYI, I was unable to build the
  minified version or update the examples, so they're out of date.

If you're interested, I also added the capacity for object
  properties, expressed using dot notation, to be used within
  expressions. However, this will need a bit more testing before I'm
  ready to commit that branch.
On 30/07/2021 10:12, Joshua Grams
  wrote:

  Merged #7 into master.
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or unsubscribe.
  [

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/JoshuaGrams/tiny-qbn/pull/7#event-5090394748", "url": "https://github.com/JoshuaGrams/tiny-qbn/pull/7#event-5090394748", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

JoshuaGrams commented 3 years ago

Oops, yeah. Probably time for me to sit down and figure out if I can use GitHub Actions or something to auto-build the minified version and re-build the examples: that stuff really shouldn't be in version control anyway.

I'd be curious to see the dot notation changes when you're happy with that, yeah. I was thinking that allowing expressions in comments within the passage would obviate the need for extending the tag-expression syntax, but (to me, at least) it feels more verbose because you need a line per requirement. So I haven't used it as much as I thought I would.

mjhawkins commented 3 years ago 
I know the feeling. I've been putting off figuring out GitHub
  Actions and BitBucket Pipelines for far too long myself.
I believe the dot notation object code is functional. I'll see if
  I can write up a sample page to act as both test case and demo
  over the next couple of days.
I have to admit that I'm still using tag mode as well for much
  the same reasons. However, I can see how the verbosity of comment
  mode might make things clearer, esp. when you have a large number
  of cards with complicated conditions.

On 30/07/2021 18:29, Joshua Grams
  wrote:

  Oops, yeah. Probably time for me to sit down and figure out if
    I can use GitHub Actions or something to auto-build the minified
    version and re-build the examples: that stuff really shouldn't
    be in version control anyway.
  I'd be curious to see the dot notation changes when you're
    happy with that, yeah. I was thinking that allowing expressions
    in comments within the passage would obviate the need for
    extending the tag-expression syntax, but (to me, at least) it
    feels more verbose because you need a line per requirement. So I
    haven't used it as much as I thought I would.
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or unsubscribe.
  [

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/JoshuaGrams/tiny-qbn/pull/7#issuecomment-890044520", "url": "https://github.com/JoshuaGrams/tiny-qbn/pull/7#issuecomment-890044520", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]