Added support for changin keys #24

JoshuaKGoldberg / Old-Deleted-FullScreenMario

An HTML5 remake of the original Super Mario Brothers - expanded for wide screens.

2.98k stars 883 forks source link

Added support for changin keys #24 #131

Closed Umigatsu closed 10 years ago

Umigatsu commented 10 years ago

Hi ! As mentioned in issue #24, I added a new menu in index.html that allow the player to change the keys of the game. For the moment it doesn't override the default settings, but I could add it if you want me to.

Hope the new menu suits your taste ;) Feel free to give me any advice to improve anything.

JoshuaKGoldberg commented 10 years ago

This seems to work well, what browsers did you test it on?

heavygunner commented 10 years ago

Wrong Link http://supermario.pw/

On Tue, Feb 18, 2014 at 5:18 AM, Sutharsan Yogeswararajah < sutharsan.neelambari@gmail.com> wrote:

What? It working fine http://sociobonanza.com/ http://sociobonanza.com/

On Tue, Feb 18, 2014 at 5:17 AM, Josh Goldberg notifications@github.comwrote:

This seems to work well, what browsers did you test it on?

Reply to this email directly or view it on GitHubhttps://github.com/Diogenesthecynic/FullScreenMario/pull/131#issuecomment-35333956 .

Umigatsu commented 10 years ago

I tested it mostly on Firefox (27.0.1) and it seems like the menu glitch on Chrome (32.0.1700.107 m) because the word Sprint is one-character too long. Sorry about that

Umigatsu commented 10 years ago

I fixed it, I hope it works now (from my testing on Chrome the menu should be fine now). Except for this issue, I can't test it on others browsers at the moment, so if someone can check it, it would be nice.

JoshuaKGoldberg commented 10 years ago

Ah good, I was wondering if that is intentional. It looks good otherwise, but:

It's hard to tell when a button was selected; there should be a visual indicator of toggle state (especially Chrome)
- Key Mapping - is slightly lowered when - Options - is selected (because of the extra border)
The inputs don't use the 8-bit style font

If you fix those (or I get bored and do it myself) I'll put it in.

Umigatsu commented 10 years ago

So i have worked on the first and last issue (now the selected button have a blue background with this hexa #0099ff, if you have an idea on a good color for it please tell me).

But I am still fighting with the slight movement : I have tried to put a transparent border of the same size but it doesn't remove the movement. Do you have any idea on that matter ?

Umigatsu commented 10 years ago

And found it. Now everything is fixed. I tested on Firefox and Chrome on Windows 8 (Desktop version). Hope everything is fine now =D