Fix false error when TSLintDisabled is true

JoshuaKGoldberg / TSLint.MSBuild

[Deprecated] An MSBuild task for running TSLint.

https://www.nuget.org/packages/TSLint.MSBuild

MIT License

15 stars 13 forks source link

Fix false error when TSLintDisabled is true #106

Closed grantborthwick closed 4 years ago

grantborthwick commented 4 years ago

When TSLintDisabled is true, TSLintErrorCode never gets set to 0, so this error task always emits an error.

Other possible solutions - I'm open to suggestions:

Check TSLintDisabled from the target conditions
Set TSLintErrorCode to 0 if TSLintDisabled is true

JoshuaKGoldberg commented 4 years ago

Hi sorry, this must have dropped off my radar! Will review today.

JoshuaKGoldberg commented 4 years ago

Actually, @grantborthwick, what is the use case for both TSLintDisabled and TSLintBreakBuildOnError being true?

grantborthwick commented 4 years ago

@JoshuaKGoldberg - one of our projects has TSLintBreakBuildOnError set to true and usually runs TSLint. I'm invoking msbuild from a local script and want to allow the process to keep going despite TSLint errors. If there are errors, we'll catch them when building from Visual Studio or from a PR build.

Right now I'm setting both TSLintDisabled and TSLintBreakBuidOnError globally to false from my script as a workaround.

JoshuaKGoldberg commented 4 years ago

This should be published as https://www.nuget.org/packages/TSLint.MSBuild/2.0.2. Enjoy!