JoshuaKGoldberg / TSLint.MSBuild

[Deprecated] An MSBuild task for running TSLint.
https://www.nuget.org/packages/TSLint.MSBuild
MIT License
15 stars 13 forks source link

Also output json file of warnings? #66

Open brettjacobson opened 7 years ago

brettjacobson commented 7 years ago

Is it possible to also have the warnings output to a json file? That way SonarQube plugins could pick it up without rerunning tslint. I expect it may be difficult to get both outputs, the one that msbuild wants and the json file output as well.

JoshuaKGoldberg commented 7 years ago

Interesting idea, I like it! A couple of thoughts:

brettjacobson commented 7 years ago

I wrote a user story to cover my scenario:

As a developer, I want TSLint to output to both .json and msbuild formats, so that I can get the VSO formatted data to show in the build summary and the json formatted data to be used later in the build process without executing TSLint a second time.

This has led me to realize that it isn't that important of a feature. There is little value in actually running TSLint as a part of msbuild during our CI builds, because its not like anyone will look at those "warnings" that would show up in the build summary. We only look at the output of TSLint in SonarQube, and that data is pulled in from the second execution of TSLint as a part of the SonarTS plugin. So the simplest solution to our issue is to just not bother executing TSLint in our Release config on the build server, and do without TSLint info being in our build summaries that no one looks at. When a future TSLint ships which allows some warnings to become errors, we'll have to revisit running TSLint during MSBuild step on the build server.

JoshuaKGoldberg commented 7 years ago

isn't that important of a feature

I disagree. Re-opening :)

TSLint is pretty close to supporting error severities: https://github.com/palantir/tslint/pull/1738