JoshuaKGoldberg / TSLint.MSBuild

[Deprecated] An MSBuild task for running TSLint.
https://www.nuget.org/packages/TSLint.MSBuild
MIT License
15 stars 13 forks source link

Build fails if "bin" folder does not exist before compilation. #79

Closed mortb closed 7 years ago

mortb commented 7 years ago

After upgrading to release 1.2.1 of TSLint the build fails on our build server. This seems to be because the TSLint build step is run before compilation in our build, so the "bin" folder is not yet created.

"C:\projects\foo\MsBuildSettings.msbuild" (default target) (1) ->
"C:\projects\foo\foo.sln" (Clean;Rebuild target) (2) -> "C:\projects\ct\foo\Code\Web\foo\foo.Web.csproj" (Rebuild target) (20:2) -> 
(TSLint target) -> 
C:\projects\foo\packages\TSLint.MSBuild.1.2.1\build\TSLint.MSBuild.targets(60,5): 
error MSB3371: The file "bin\\foo.Web.TSLint.timestamp.txt" cannot be created. 
Could not find a part of the path 'C:\projects\foo\Code\Web\foo.Web\bin\foo.Web.TSLint.timestamp.txt'. 
[C:\projects\foo\Code\Web\foo.Web\foo.Web.csproj]
JoshuaKGoldberg commented 7 years ago

Thanks for the bug report @mortb! Your fix in https://github.com/mortb/TSLint.MSBuild/commit/347d2b226cba9ffc5aa6008ce5f315e5bfecf815 looks good. Could you send a PR?