Some fixes for the package

JoshuaKGoldberg / TSLint.MSBuild

[Deprecated] An MSBuild task for running TSLint.

https://www.nuget.org/packages/TSLint.MSBuild

MIT License

15 stars 13 forks source link

Some fixes for the package #85

Closed isc30 closed 6 years ago

isc30 commented 6 years ago

Hi, I thought the package was unmaintained and we needed some urgent changes on it for our application so I forked it and added some fixes (improved error messages, dot escape, quotes in the command, fix output file) etc.

The main problem was:

Build
Get the TSLint errors
Build again
No errors (because of the output file)

In case you like those changes I can create a PR for you. Check the changes here: https://github.com/JoshuaKGoldberg/TSLint.MSBuild/compare/master...isc30:master

JoshuaKGoldberg commented 6 years ago

Hey, thanks for the changes! The package is certainly maintained; I haven't had a need to push any changes in a while. (thanks for the reminder to triage GH issues, though!)

Could you file separate issues & send pull requests for the issues you came across? It's a little hard to understand just from that one plain diff what the contexts behind all your changes are.

isc30 commented 6 years ago

Sure! I will, thanks 👍

isc30 commented 6 years ago

I hope you liked those changes, they help a lot when using this package on a daily basis Thanks a lot!

JoshuaKGoldberg commented 6 years ago

@isc30 these changes made my day 💖. Thanks so much!