JoshuaKGoldberg / TSLint.MSBuild

[Deprecated] An MSBuild task for running TSLint.
https://www.nuget.org/packages/TSLint.MSBuild
MIT License
15 stars 13 forks source link

Doesn't work with Visual Studio 2017 without overridding TSLintCli #98

Closed cdhawan closed 5 years ago

cdhawan commented 6 years ago

In VS2017 packages can be restored to "%UserProfile%.nuget\packages" based on configuration or new csproj format.

In this case TSLintCli is path is not resolved, until we override it. Changing the last search path to following help.

  <TSLintPotentialCli Include="$(MSBuildThisFileDirectory)..\..\..\tslint\$(TSLintVersion)\tools\node_modules\tslint\bin\tslint" /> 

Can this project be updated to uptake this ?

JoshuaKGoldberg commented 6 years ago

Thanks for pointing this out! A PR to add this in would be great, yes please!

JoshuaKGoldberg commented 5 years ago

Released as 1.4.2: https://www.nuget.org/packages/TSLint.MSBuild/1.4.2 🚀