🛠 Tooling: Investigate simplifying release commenter version name

JoshuaKGoldberg / create-typescript-app

Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. 💝

MIT License

1.2k stars 75 forks source link

🛠 Tooling: Investigate simplifying release commenter version name #1115

Open JoshuaKGoldberg opened 10 months ago

JoshuaKGoldberg commented 10 months ago

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview

Following #427 -> #428: per https://github.com/apexskier/github-release-commenter/issues/432, it looks like ${{ payload.release.tag_name }} should be usable to get the tag name of the released version. It'd be nice to use that instead of having to manually run a command: https://github.com/JoshuaKGoldberg/create-typescript-app/blob/d53c4eea73e084307a2d5eb9386727d0e3bf91ac/.github/workflows/post-release.yml#L8

Investigation required. If this strategy does work, hooray! Accepting PRs!

Additional Info

No response

github-actions[bot] commented 1 month ago

:tada: This is included in version v1.73.1 :tada:

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg commented 1 month ago

Ah, wrong link. Will fix.

JoshuaKGoldberg commented 1 month ago

I really hate debugging GitHub Actions...


Invalid workflow file: .github/workflows/post-release.yml#L11The workflow is not valid. .github/workflows/post-release.yml (Line: 11, Col: 29): Unrecognized named-value: 'payload'. Located at position 1 within expression: payload.release.tag_name
--

[Invalid workflow file: .github/workflows/post-release.yml#L11](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/11394888134/workflow)
The workflow is not valid. .github/workflows/post-release.yml (Line: 11, Col: 29): Unrecognized named-value: 'payload'. Located at position 1 within expression: payload.release.tag_name

JoshuaKGoldberg commented 1 month ago

Things are back to how they were in #1666. Still accepting PRs on this issue...