JoshuaKGoldberg / create-typescript-app

Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. 💝
MIT License
933 stars 69 forks source link

🐛 Bug: eslint does not report problems on `tasks.json` in VS Code #1219

Open danvk opened 9 months ago

danvk commented 9 months ago

Bug Report Checklist

Expected

I created a new repo yesterday using create-typescript-app using the "everything" setting (woo!). I set up a few tasks in VS Code's tasks.json and pushed a PR, at which point I noticed that I was getting some eslint errors because of unsorted keys in my tasks.json.

These were reported via GitHub Actions CI and when I run pnpm lint, but they were not reported in VS Code like lint errors in .ts files are.

Actual

I would expect eslint issues in tasks.json to be reported in VS Code (so that I can quick fix them!).

Additional Info

I noticed that "json" is in the eslint.probe list in .code/settings.json, but maybe it also needs to be told about JSON files some other place?

Here's the PR and repo: https://github.com/danvk/gravlax/pull/3

JoshuaKGoldberg commented 9 months ago

@all-contributors please add @danvk for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action. Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed. ...and of course, thank you for contributing! 💙

allcontributors[bot] commented 9 months ago

@JoshuaKGoldberg

I've put up a pull request to add @danvk! :tada:

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

JoshuaKGoldberg commented 8 months ago

Hmm, looks like using eslint.probe for jsonc files isn't yet supported in vscode-eslint: https://github.com/microsoft/vscode-eslint/issues/1786. Marking as blocked pending discussion there.

Worst case scenario, we can go back to eslint.validate. But that's described as old and legacy so I'd rather not for a bit.