JoshuaKGoldberg / create-typescript-app

Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. 💝
MIT License
1.21k stars 75 forks source link

🐛 Bug: 'common' preset has knip errors upon creation #1635

Closed JoshuaKGoldberg closed 3 months ago

JoshuaKGoldberg commented 3 months ago

Bug Report Checklist

Expected

Running npx create-typescript-app --base common --mode create should create a repo that has no pnpm run lint:knip errors.

Actual

Run pnpm lint:knip

> cta-temp-test@0.0.0 lint:knip /home/runner/work/cta-temp-test/cta-temp-test
> knip

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
Unused devDependencies (4)
@eslint-community/eslint-plugin-eslint-comments  package.json
@types/eslint-plugin-markdown                    package.json
eslint-plugin-jsdoc                              package.json
eslint-plugin-regexp                             package.json
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

sigh

Additional Info

This isn't caught by the end-to-end creation test because that one uses --base everything.

💖

github-actions[bot] commented 3 months ago

:tada: This is included in version v1.71.1 :tada:

The release is available on:

Cheers! 📦🚀