Only send claim notifications to the relevant users

JoshuaKGoldberg / intern-assassins-2016

Node+Mongo app to run a game of assassins

MIT License

0 stars 1 forks source link

Only send claim notifications to the relevant users #133

Open JoshuaKGoldberg opened 8 years ago

JoshuaKGoldberg commented 8 years ago

Spin-off of #112.

NotificationCause	Socket notification	Email notification
Death	Victim only	Victim only
Kill	Everybody	Killer only
ClaimToKiller	Nobody	Killer only
ClaimToVictim	Killer only	Killer only

Right now, socket.io blindly broadcasts all notifications to every user. Instead there should be an individual room for each user that the user will connect to for their specific notifications.

juliusl commented 8 years ago

I'll be taking a look at this shortly.

JoshuaKGoldberg commented 8 years ago

Great!

juliusl commented 8 years ago

Just to clarify the Email notification portion of that table is already working?

JoshuaKGoldberg commented 8 years ago

:+1: