search

JoshuaKGoldberg / package.json-validator

Tools to validate package.json files
MIT License
107 stars 26 forks source link

Support scoped modules. #48

Closed hemanth closed 2 months ago

hemanth commented 8 years ago

^

bahmutov commented 8 years ago

+1 on this one

hemanth commented 8 years ago

/me paws @gorillamania

bahmutov commented 8 years ago

I switched to using @hemanth fork in my https://github.com/bahmutov/grunt-nice-package for now

LinusU commented 7 years ago

ping @gorillamania would really appreciate getting this merged. I'd be happy to step up as a maintainer if you no longer have time to devote to this project :)

TechNickAI commented 7 years ago

Yes please! Note this has conflicts that prevent it from being merged. What is your npm username?I'll add you as a maintainer

LinusU commented 7 years ago

Glad to hear! I'm linusu on npm :)

TechNickAI commented 7 years ago

@LinusU I've added you as a collaborator on this repo and on NPM. Really appreciate the help!

hemanth commented 7 years ago

Meow.

JoshuaKGoldberg commented 5 months ago

@hemanth I don't have permissions to push the suggestion (or merge conflict resolutions) to your branch. Would you be up for either doing that yourself or giving me permission to?

I know it's been a long time, but I'd love to get this in 😄

hemanth commented 5 months ago

@JoshuaKGoldberg I guess @bahmutov has a better fix :)

JoshuaKGoldberg commented 5 months ago

Sorry, I don't follow - what's the better fix?

hemanth commented 5 months ago

https://github.com/TechNickAI/package.json-validator/pull/48#issuecomment-161726665

Looks like my fork is deleted, so ^ :|

JoshuaKGoldberg commented 5 months ago

Ah, gotcha.

For context: I want to accept these changes and give you credit as the author. Do you want to re-fork and send a new PR?

If not / you don't have time, no worries, I can always make them myself and list you as a co-author. But I'd feel bad doing that without giving you the opportunity to be the primary author. 🙂

hemanth commented 5 months ago

@JoshuaKGoldberg That's ok, FOSS FTW! ❤️