JoshuaKGoldberg / prettier-plugin-curly

Prettier plugin to enforce consistent brace style for all control statements. 🥌
MIT License
55 stars 3 forks source link

🐛 Bug: prettier plugin collision #386

Open hyoban opened 7 months ago

hyoban commented 7 months ago

Bug Report Checklist

Expected

Works fine with other prettier plugins like prettier-plugin-organize-imports.

Actual

Can not use this with prettier-plugin-organize-imports.

Additional Info

Maybe the reason is you are overriding preprocess?

https://github.com/JoshuaKGoldberg/prettier-plugin-curly/blob/c56f274bacf294db5191d67ae04c44afd8c0d7fc/src/index.ts#L8-L14

Some links may be useful

JoshuaKGoldberg commented 7 months ago

Can not use this with prettier-plugin-organize-imports.

Could you post a reproduction please? It's hard to triage without knowing what you mean, and this issue is pretty sparse in details.

hyoban commented 7 months ago

Sorry for missing reproduction, it's here.

https://github.com/hyoban-repro/prettier-plugin-curly-collision

JoshuaKGoldberg commented 7 months ago

Gotcha - that is spooky. Thanks!

JoshuaKGoldberg commented 7 months ago

@all-contributors please add @hyoban for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action. Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed. ...and of course, thank you for contributing! 💙

allcontributors[bot] commented 7 months ago

@JoshuaKGoldberg

I've put up a pull request to add @hyoban! :tada:

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

cmaciasjimenez commented 7 months ago

I'm having the same issue with IanVS/prettier-plugin-sort-imports. There's some kind of collision and the enforced curly is not working 😔