search

JoshuaLampert / DispersiveShallowWater.jl

Structure-preserving numerical methods for dispersive shallow water models
https://joshualampert.github.io/DispersiveShallowWater.jl/
MIT License
15 stars 3 forks source link

Factorize matrices for `BBMBBMVariableEquations1D` #112

Closed JoshuaLampert closed 5 months ago

JoshuaLampert commented 5 months ago

Same as #108, but for the variable bathymetry case.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.80%. Comparing base (25e6480) to head (3a07113).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## ========================================== + Coverage 96.76% 96.80% +0.03% ========================================== Files 17 17 Lines 1206 1221 +15 ========================================== + Hits 1167 1182 +15 Misses 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JoshuaLampert commented 5 months ago

It looks like some tolerances and/or reference values may need to be adjusted

Yes, this was also the case for the other PR. I will do that.