search

JoshuaLampert / DispersiveShallowWater.jl

Structure-preserving numerical methods for dispersive shallow water models
https://joshualampert.github.io/DispersiveShallowWater.jl/
MIT License
15 stars 3 forks source link

rename Serre-Green-Naghdi source file #136

Closed ranocha closed 2 months ago

JoshuaLampert commented 2 months ago

Thanks! Can you update the file name in equations/equations.jl please such that the tests don't fail?

Do you know if GitHub is smart enough to put my review comments in the SGN source file including suggestions in #135 in the correct places after merging this PR into main and main into hr/serre_green_naghdi or will they be outdated and thus not as easy to accept?

ranocha commented 2 months ago

Thanks! Can you update the file name in equations/equations.jl please such that the tests don't fail?

Sorry, should be done now...

Do you know if GitHub is smart enough to put my review comments in the SGN source file including suggestions in #135 in the correct places after merging this PR into main and main into hr/serre_green_naghdi or will they be outdated and thus not as easy to accept?

I don't know. Let's just try?

JoshuaLampert commented 2 months ago

I don't know. Let's just try?

I see you already pushed most of my suggestions in the other PR already. So we can't loose those. I just made some more suggestions that were still pending. Maybe we go through those first quickly before merging this PR such that they don't get lost if GitHub is not smart enough?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.00%. Comparing base (c5431b2) to head (8c3b29e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #136 +/- ## ======================================= Coverage 97.00% 97.00% ======================================= Files 18 18 Lines 1369 1369 ======================================= Hits 1328 1328 Misses 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JoshuaLampert commented 2 months ago

CI failure looks spurious. So I'm going to merge this.