It would be nice to unify identical physical setups' names. Right now, initial_condition_convergence_test is used for some solitary wave (or soliton) solutions - but we use initial_condition_soliton for the hyperbolic SGN equations since it's not an analytical solution for the hyperbolic approximation
This came up in https://github.com/JoshuaLampert/DispersiveShallowWater.jl/pull/139#discussion_r1720820803_
It would be nice to unify identical physical setups' names. Right now,
initial_condition_convergence_testis used for some solitary wave (or soliton) solutions - but we useinitial_condition_solitonfor the hyperbolic SGN equations since it's not an analytical solution for the hyperbolic approximation